Add TrustedProxies configuration to support proxy IPs in Gin#137
Merged
Add TrustedProxies configuration to support proxy IPs in Gin#137
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Free Tier Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches request client-IP determination, which can affect logging and any IP-based controls (e.g., rate limiting) if misconfigured, though the default remains the safer “trust none” behavior.
Overview
Adds a new
trusted-proxiesconfig field (YAMLtrusted-proxies) and documents it indocs/config.ymlfor deployments behind reverse proxies.Updates server initialization to apply
gin.Engine.SetTrustedProxiesfrom config (or explicitly disable trusting proxy headers when unset), ensuringClientIP()behavior matches the configured proxy trust model.Written by Cursor Bugbot for commit f127ae9. This will update automatically on new commits. Configure here.